Beefy Boxes and Bandwidth Generously Provided by pair Networks
We don't bite newbies here... much
 
PerlMonks  

Re: Re: Re: Re: Style, style, style

by belden (Friar)
on Sep 08, 2002 at 18:02 UTC ( #196063=note: print w/replies, xml ) Need Help??


in reply to Re: Re: Re: Style, style, style
in thread Style, style, style

I regularly see one of these in a co-worker's code:

sub blah { my ( $foo, $bar, $baz ) = ( shift, shift ); }

Perhaps not too bad in a short list of shifts. But terrible when invoked as:

shazam ( 0, 6, 7, $index, $arrayref, $hashref ); ... sub shazam { my ( $foo, $bar, $baz, $bup, $quz, $pig, $cow ) = (shift, shift, shi +ft, shift, shift, shift); }
Quick, was $cow passed in via @_ or simply instantiated?

update: added another egregious example, shazam

blyman
setenv EXINIT 'set noai ts=2'

Replies are listed 'Best First'.
Re^5: Style, style, style
by Aristotle (Chancellor) on Sep 10, 2002 at 16:25 UTC
    You might want to at least introduce your co-worker to the wonders of splice: my ($foo, $bar, $baz, $bup, $quz, $pig, $cow) = splice @_, 0, 6;

    Makeshifts last the longest.

Log In?
Username:
Password:

What's my password?
Create A New User
Node Status?
node history
Node Type: note [id://196063]
help
Chatterbox?
and the web crawler heard nothing...

How do I use this? | Other CB clients
Other Users?
Others avoiding work at the Monastery: (5)
As of 2021-06-24 10:29 GMT
Sections?
Information?
Find Nodes?
Leftovers?
    Voting Booth?
    What does the "s" stand for in "perls"? (Whence perls)












    Results (125 votes). Check out past polls.

    Notices?