Beefy Boxes and Bandwidth Generously Provided by pair Networks
XP is just a number

Re: Checking File Types

by Chmrr (Vicar)
on Oct 10, 2002 at 01:34 UTC ( #204078=note: print w/replies, xml ) Need Help??

in reply to Checking File Types

Be the perl interpreter for a second, and run though the for loop in your mind:

  1. OK, so @alltypes is (".gif", ".jpg", ".jpeg", ".jpe", ".jfif")
  2. For each element, print an error unless the string matches the extension.
  3. So it doen't print for ".gif", but then it continues on to check if it ends in ".jpg" and falls over!

So what you're looking at is an and instead of an or. The simple fix in this case is to make use of grep:

unless (grep {$ext eq $_} @alltypes) { error("Your image needs to be a GIF of JPEG file!"); }

..thus, if the grep returns a false value, (the empty list) it means that none of the matches worked, so we need to print an error.

As a side note, proper indenting will make it easier for yourself and others to see what's going on at a glance.

Update: See rob_au's answer for how not to reinvent the wheel.

perl -pe '"I lo*`+$^X$\"$]!$/"=~m%(.*)%s;$_=$1;y^`+*^e v^#$&V"+@( NO CARRIER'

Log In?

What's my password?
Create A New User
Node Status?
node history
Node Type: note [id://204078]
[LanX]: belg4mit: thanks for fixing your CB log!

How do I use this? | Other CB clients
Other Users?
Others meditating upon the Monastery: (10)
As of 2018-06-23 15:03 GMT
Find Nodes?
    Voting Booth?
    Should cpanminus be part of the standard Perl release?

    Results (125 votes). Check out past polls.