Beefy Boxes and Bandwidth Generously Provided by pair Networks
Think about Loose Coupling
 
PerlMonks  

comment on

( [id://3333]=superdoc: print w/replies, xml ) Need Help??

It looks like you're doing pretty well on your own just from seeing the code change over a few minutes. It's not obvious that you need to extract array elements one by one. There are examples of how to pass parameters to subroutines here: perlsub. The math you have to do is just adding digits-- the trickier part is separating the digits, but you already know how to do that (though you may not know it). You can add them in a loop once they're split.

One suggestion I'd make that you probably won't catch on your own this time through, is that you should make your hash all one case and force the month name to that case for comparison. That way the input can be 'Mar', 'MAR', 'MaR', or any other case combination.

You might also rewrite how you read the file-- it looks from the assignment like you're supposed to do it a line at a time instead of grabbing all the lines at once into an array. A problem with perl is there's more than one way to do everything.

And just to help people who are going to add comments, you should put in a note like "edit: (stuff that I changed)" when you edit it. When you're changing the code, just add a little comment.


In reply to Re: Manipulating data from a file by bitingduck
in thread Manipulating data from a file by CrimSin

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post; it's "PerlMonks-approved HTML":



  • Are you posting in the right place? Check out Where do I post X? to know for sure.
  • Posts may use any of the Perl Monks Approved HTML tags. Currently these include the following:
    <code> <a> <b> <big> <blockquote> <br /> <dd> <dl> <dt> <em> <font> <h1> <h2> <h3> <h4> <h5> <h6> <hr /> <i> <li> <nbsp> <ol> <p> <small> <strike> <strong> <sub> <sup> <table> <td> <th> <tr> <tt> <u> <ul>
  • Snippets of code should be wrapped in <code> tags not <pre> tags. In fact, <pre> tags should generally be avoided. If they must be used, extreme care should be taken to ensure that their contents do not have long lines (<70 chars), in order to prevent horizontal scrolling (and possible janitor intervention).
  • Want more info? How to link or How to display code and escape characters are good places to start.
Log In?
Username:
Password:

What's my password?
Create A New User
Domain Nodelet?
Chatterbox?
and the web crawler heard nothing...

How do I use this?Last hourOther CB clients
Other Users?
Others surveying the Monastery: (4)
As of 2024-03-28 20:00 GMT
Sections?
Information?
Find Nodes?
Leftovers?
    Voting Booth?

    No recent polls found