I like to use the Ternaries as suggested in the book "Perl Best Practices".
use strict;
use warnings;
sub print_response;
my $response_code = 200;
my $response_content = "All's well!";
use constant OK => 0;
use constant BAD_INPUT => 1;
use constant SERVICE_ACCESS_ERROR => 31;
use constant SERVICE_EXECUTION_ERROR => 32;
use constant SERVICE_ERROR => 30;
use constant UNDEFINED => 255;
$_ = $response_code;
my $return_status
= /200/ ? OK
: /400/ ? BAD_INPUT
: /403/ ? SERVICE_ACCESS_ERROR
: /500/ ? SERVICE_EXECUTION_ERROR
: /503/ ? SERVICE_ERROR
: UNDEFINED
;
print_response $response_content if $return_status == OK;
exit $return_status;
The constants may be overkill, but if the names are important enough to include as comments, why not make them part of the actual perl code?
UPDATE -- Corrected sense of if statement
-
Are you posting in the right place? Check out Where do I post X? to know for sure.
-
Posts may use any of the Perl Monks Approved HTML tags. Currently these include the following:
<code> <a> <b> <big>
<blockquote> <br /> <dd>
<dl> <dt> <em> <font>
<h1> <h2> <h3> <h4>
<h5> <h6> <hr /> <i>
<li> <nbsp> <ol> <p>
<small> <strike> <strong>
<sub> <sup> <table>
<td> <th> <tr> <tt>
<u> <ul>
-
Snippets of code should be wrapped in
<code> tags not
<pre> tags. In fact, <pre>
tags should generally be avoided. If they must
be used, extreme care should be
taken to ensure that their contents do not
have long lines (<70 chars), in order to prevent
horizontal scrolling (and possible janitor
intervention).
-
Want more info? How to link or
or How to display code and escape characters
are good places to start.
|