I have a small piece of code ($error_sub) that I need to use in two places within the same subroutine. It looks some like this (a Catalyst App).

sub myaction : Chained('.') PathPart('myaction') POST {
    my ( $self, $c ) = @_;

    my $form = MyApp::Form->new;
    $form->process(params => $c->req->body_params);

    my $error_sub = sub {
        $c->response->status(400);
        $c->stash(
            results => {
                form => $form->render,
            },
        );
        $c->detach();
    };

    if ( $form->is_valid ) {
        try {
            $form->update_model;
        }
        catch($e) {
            $form->add_form_error($e);
            $error_sub->();
        };
    }
    else {
        $error_sub->();
    }
}
[download]

Scope is not an issue in this context as far as I can tell.
My question is whether there are benefits to using lexical subs in this situation. I would end up with

   my sub error {
        $c->response->status(400);
        $c->stash(
            results => {
                form => $form->render,
            },
        );
        $c->detach();
   }
[download]

Would I be save a CPU cycle or a byte of RAM using lexical subs, or is there any other benefits? Thanks in advance, Dermot

---

---

Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!

Titles consisting of a single word are discouraged, and in most cases are disallowed outright.

Read Where should I post X? if you're not absolutely sure you're posting in the right place.

Please read these before you post! —

• How do I compose an effective node title?
• How do I post a question effectively?
• Markup in the Monastery

Posts may use any of the Perl Monks Approved HTML tags:

a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr

You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)

	For:		Use:
	&		&
	<		&lt;
	>		&gt;
	[		&#91;
	]		&#93;

Link using PerlMonks shortcuts! What shortcuts can I use for linking?

See Writeup Formatting Tips and other pages linked from there for more info.