Seems a waste to copy the sql from, e.g.,
$self->{SQL}->{test} to
$self->{test}, and I would assume
$self is already a closure, so you shouldn't need to pass it to the sub, and the sth itself can be a closure and so not stored directly in
$self, so I might go with:
for ( keys %{$self->{SQL}} ) {
my $name = $_;
my $dbh = $self->{DBO};
my $sth = $dbh->prepare($self->{SQL}{$name};
$self->{STH}{$name} = sub {
my @res;
$sth->execute(@_);
while (my $dbrow = $sth->fetchrow_hashref()) {
# Not sure why you're making a reference to a hashref here
push @res, \$dbrow;
}
return \@res;
};
}
And if you don't need to have references to hashrefs in the arrayref, then the execute() and the while loop can be replaced with:
my $res = $dbh->selectall_arrayref($sth, {Slice => {}}, @_);
return $res;
Or even (only $sth needs to be a closure):
return $sth->{Database}->selectall_arrayref($sth, {Slice => {}}, @_);
-
Are you posting in the right place? Check out Where do I post X? to know for sure.
-
Posts may use any of the Perl Monks Approved HTML tags. Currently these include the following:
<code> <a> <b> <big>
<blockquote> <br /> <dd>
<dl> <dt> <em> <font>
<h1> <h2> <h3> <h4>
<h5> <h6> <hr /> <i>
<li> <nbsp> <ol> <p>
<small> <strike> <strong>
<sub> <sup> <table>
<td> <th> <tr> <tt>
<u> <ul>
-
Snippets of code should be wrapped in
<code> tags not
<pre> tags. In fact, <pre>
tags should generally be avoided. If they must
be used, extreme care should be
taken to ensure that their contents do not
have long lines (<70 chars), in order to prevent
horizontal scrolling (and possible janitor
intervention).
-
Want more info? How to link
or How to display code and escape characters
are good places to start.