Unfortunately fat comma is only going half way to be a hash separator (which is the normal use case) and there are already many use cases exploiting list context for syntactic sugar.
See for instance Re^4: Stop Using Perl and further discussion
Anyway some remarks:
- you should have returned undef in your function, since it was never intended to be used in list context and a call in scalar context would always result to undef anyway.
- you could have checked wantarray otherwise
- prepending scalar is the normal idiomatic way to force scalar context (sic)
- personally I would have chosen "" . call() to get am explicit string
- your use of each and keys is a bit worrying, because it's globally resetting the iterator of that hash °
update
°) a simple ($key) = %$hash_ref would have done the trick better
-
Are you posting in the right place? Check out Where do I post X? to know for sure.
-
Posts may use any of the Perl Monks Approved HTML tags. Currently these include the following:
<code> <a> <b> <big>
<blockquote> <br /> <dd>
<dl> <dt> <em> <font>
<h1> <h2> <h3> <h4>
<h5> <h6> <hr /> <i>
<li> <nbsp> <ol> <p>
<small> <strike> <strong>
<sub> <sup> <table>
<td> <th> <tr> <tt>
<u> <ul>
-
Snippets of code should be wrapped in
<code> tags not
<pre> tags. In fact, <pre>
tags should generally be avoided. If they must
be used, extreme care should be
taken to ensure that their contents do not
have long lines (<70 chars), in order to prevent
horizontal scrolling (and possible janitor
intervention).
-
Want more info? How to link
or How to display code and escape characters
are good places to start.
|
