In addition to what other monks have already said, please note that glob "*" or <$dir/*> will return a list of files with their path. So, @files will contain things such as /some/directory/here/foo.txt. This is OK for reading the files in the foreach loop (and this is often what you want), but this:

    $outputfile = $inputfile;
    open NEWFILE, '>', "$dir/subdirectory/$outputfile" or die "... $!"
+;
[download]

will probably fail, or, at the very least, not work as expected, because the new file to be created will look like /some/directory/here/subdirectory/some/directory/here/foo.txt which is presumably not what you want. So you probably to extract the file name (without the path) before assigning outputfile or use some other means for creating the list of files.

---

---

• Are you posting in the right place? Check out Where do I post X? to know for sure.
• Posts may use any of the Perl Monks Approved HTML tags. Currently these include the following:

  <code> <a> <b> <big> <blockquote> <br /> <dd> <dl> <dt> <em> <font> <h1> <h2> <h3> <h4> <h5> <h6> <hr /> <i> <li> <nbsp> <ol> <p> <small> <strike> <strong> <sub> <sup> <table> <td> <th> <tr> <tt> <u> <ul>

• Snippets of code should be wrapped in <code> tags not <pre> tags. In fact, <pre> tags should generally be avoided. If they must be used, extreme care should be taken to ensure that their contents do not have long lines (<70 chars), in order to prevent horizontal scrolling (and possible janitor intervention).
• Want more info? How to link or How to display code and escape characters are good places to start.