Use hash keys to avoid lots of variables. Push the field names, values onto arrays and use join to create the statement
#!perl
use strict;
my $user_id = 1;
my $old = {
password => 'password', forename => 'forename',
lastname => 'lastname', business => 'business',
city => 'city', zip => 'zip'
};
my $new = {
password => 'password1', forename => 'forename',
lastname => 'lastname1', business => 'business',
city => 'city1', zip => 'zip1'
};
my @fields;
my @values;
# compare old v new
for (sort keys %$new){
if ($new->{$_} ne $old->{$_}){
push @fields,"$_ = ?";
push @values,$new->{$_};
}
}
# skip if no change
if (@fields == 0){
print "No update required\n";
} else {
# build sql
my $fields = join ',',@fields;
my $stmt = "
UPDATE table
SET $fields
WHERE user_id = ?";
# add id
push @values,$user_id;
# prepare and execute sql
print "$stmt\n(@values)\n";
}
poj
-
Are you posting in the right place? Check out Where do I post X? to know for sure.
-
Posts may use any of the Perl Monks Approved HTML tags. Currently these include the following:
<code> <a> <b> <big>
<blockquote> <br /> <dd>
<dl> <dt> <em> <font>
<h1> <h2> <h3> <h4>
<h5> <h6> <hr /> <i>
<li> <nbsp> <ol> <p>
<small> <strike> <strong>
<sub> <sup> <table>
<td> <th> <tr> <tt>
<u> <ul>
-
Snippets of code should be wrapped in
<code> tags not
<pre> tags. In fact, <pre>
tags should generally be avoided. If they must
be used, extreme care should be
taken to ensure that their contents do not
have long lines (<70 chars), in order to prevent
horizontal scrolling (and possible janitor
intervention).
-
Want more info? How to link
or How to display code and escape characters
are good places to start.