it being perl? Your boss?
If you make errors like these it is likely not do do what you expect it to do.
- I used code tags
- I restyled the code for readability
- I fixed all obvious errors
- I commented on the changes with # <-
- I replaced the unmaintained parser with the right one: this is the main reason I reply.
HTH
use strict; # <- always use strict
use warnings; # <- and warnings
use Spreadsheet::WriteExcel; # <- missing declaration
#use Spreadsheet::XLSX; # <- this module is *STRONGLY* di
+scouraged!
use Spreadsheet::ParseXLSX; # <- use this one instead
#my $excel = Spreadsheet::XLSX->new ("/tmp/temp.xlsx"); # <- do not us
+e Spreadsheet::XLSX
my $excel = Spreadsheet::ParseXLSX->new->parse ("/tmp/temp.xlsx");
# print $excel; # <- you cannot simply print an object and hope it wri
+tes a file
# if you want to see what this is use Data::Peek or Data::Dumper
#my @array; # <- unused
#my $workbook = Excel::Writer::XLSX->new ("perl.xlsx");
# ^--- Your code uses ->addworksheet, which is Spreadsheet::WriteExcel
+ syntax and
# not supported by Excel::Writer::XLSX, so you obviously do not w
+ant this line
my $FILENAME = "/tmp/Newfile.xls"; # <- used but commented out
my $workbook = Spreadsheet::WriteExcel->new ($FILENAME); # <-- no qu
+otes needed
# ^--- variable used twice
my $worksheet1 = $workbook->addworksheet ("Worksheet1");
$worksheet1->write ("A1", "Hi Excel!");
foreach my $sheet (@{$excel->{Worksheet}}) {
print "Sheet: $sheet->{Name}\n"; # <- not really a good example fo
+r printf
$sheet->{MaxRow} ||= $sheet->{MinRow};
foreach my $row ($sheet->{MinRow} .. $sheet->{MaxRow}) {
$sheet->{MaxCol} ||= $sheet->{MinCol};
foreach my $col ($sheet->{MinCol} .. $sheet->{MaxCol}) {
my $cell = $sheet->{Cells}[$row][$col] or next;
printf "(%3d, %3d) => %s\n", $row, $col, $cell->{Val};
my $temp = $cell->{Val};
$worksheet1->write ($row, $col, $cell->{Val});
}
}
last; # <- missing ;
} # <- missing }
That code correctly created /tmp/Newfile.xls with one sheet named Worksheet1.
Enjoy, Have FUN! H.Merijn
-
Are you posting in the right place? Check out Where do I post X? to know for sure.
-
Posts may use any of the Perl Monks Approved HTML tags. Currently these include the following:
<code> <a> <b> <big>
<blockquote> <br /> <dd>
<dl> <dt> <em> <font>
<h1> <h2> <h3> <h4>
<h5> <h6> <hr /> <i>
<li> <nbsp> <ol> <p>
<small> <strike> <strong>
<sub> <sup> <table>
<td> <th> <tr> <tt>
<u> <ul>
-
Snippets of code should be wrapped in
<code> tags not
<pre> tags. In fact, <pre>
tags should generally be avoided. If they must
be used, extreme care should be
taken to ensure that their contents do not
have long lines (<70 chars), in order to prevent
horizontal scrolling (and possible janitor
intervention).
-
Want more info? How to link
or How to display code and escape characters
are good places to start.
|