Beefy Boxes and Bandwidth Generously Provided by pair Networks
The stupid question is the question not asked
 
PerlMonks  

comment on

( [id://3333]=superdoc: print w/replies, xml ) Need Help??

brassmon_k: there are a few things that you need to do before you should start tackling issues like this. First, good formatting does not indicate good code, but poor formatting almost always indicates bad code. Further, any code over just a few lines needs to have strict and warnings turned on. There are exceptions to that rule, but you need to really apply and understand these rules before you break them. Also, try to factor out common elements in your code and then always, always, always test system calls for failure (in the code above, this is the open statement we're worried about).

Applying these rules of thumb to your code and using a split instead of a regex, we get the following:

#!/usr/bin/perl -w use strict; my $file = "/dave/MVPTEST/mvpdoc"; print "DateSearch = d\n"; print "Timesearch = t\n"; my $choice; do { print "Make Your Choice: "; chomp( $choice = <STDIN> ); } until ( $choice =~ /^[DdTt]/ ); chomp(my $data = <STDIN>); # this will be the date or the time open FILE, "< $file" or die "Cannot open $file for reading $!"; foreach my $line (<FILE>) { my ( $in_date, $in_time ) = (split /\s+/, $line)[4,5]; if ( ( $choice =~ /^[dD]/ && $data eq $in_date ) || ( $data eq $in +_time ) ) { print "\n$line\n"; } } close FILE;

There are plenty of ways to clean that up from there. As for your original question, check out the Date::Calc module.

Hope this helps and Happy New Year! :)

Cheers,
Ovid

Join the Perlmonks Setiathome Group or just click on the the link and check out our stats.


In reply to (Ovid) Re: Get number ranges from files internally? by Ovid
in thread Get number ranges from files internally? by brassmon_k

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post; it's "PerlMonks-approved HTML":



  • Are you posting in the right place? Check out Where do I post X? to know for sure.
  • Posts may use any of the Perl Monks Approved HTML tags. Currently these include the following:
    <code> <a> <b> <big> <blockquote> <br /> <dd> <dl> <dt> <em> <font> <h1> <h2> <h3> <h4> <h5> <h6> <hr /> <i> <li> <nbsp> <ol> <p> <small> <strike> <strong> <sub> <sup> <table> <td> <th> <tr> <tt> <u> <ul>
  • Snippets of code should be wrapped in <code> tags not <pre> tags. In fact, <pre> tags should generally be avoided. If they must be used, extreme care should be taken to ensure that their contents do not have long lines (<70 chars), in order to prevent horizontal scrolling (and possible janitor intervention).
  • Want more info? How to link or How to display code and escape characters are good places to start.
Log In?
Username:
Password:

What's my password?
Create A New User
Domain Nodelet?
Chatterbox?
and the web crawler heard nothing...

How do I use this?Last hourOther CB clients
Other Users?
Others wandering the Monastery: (5)
As of 2024-04-23 17:22 GMT
Sections?
Information?
Find Nodes?
Leftovers?
    Voting Booth?

    No recent polls found