1) Most databases support unique id keys for tables. If you set up the employee database that the ID must be unique, and then try to insert a conflicting record, you'll get an error from DBI. Otherwise, it's probably just as easy to use either method; since rows() is a DBI level and not database level, it'll be portable anyway.

2) Instead of worrying about quotes, you should use placeholders in the DBI statement, such as:

  $SQL = "INSERT INTO EMPLOYEE (
              EMPLOYEE_NUMBER, FIRST_NAME, LAST_NAME, INFORMATION_DATE
+)
              VALUES (?, ?, ?, SYSDATE)"
+;
  $sth = $dbh->prepare($SQL);
  $sth->execute( $employee_number, $first_name, $last_name );
[download]

When you use placeholders, all variables are quoted appropriately to escape \' and \" constructs as well as other characters that might cuase the DB trouble. This is better than having to roll out your own.

Finally, not asked, but you're checking for errors in a very odd way. DBI statements don't die, so using eval won't catch errors. Instead, you should check the error status via the $DBI::errstr variable, and do this after every "prepare" and "execute" statement, such as

  $SQL = "INSERT INTO EMPLOYEE (
              EMPLOYEE_NUMBER, FIRST_NAME, LAST_NAME, INFORMATION_DATE
+)
              VALUES (?, ?, ?, SYSDATE)"
+;
  $sth = $dbh->prepare($SQL) or die $DBI::errstr;
  $sth->execute( $employee_number, $first_name, $last_name ) or die $D
+BI::errstr;
[download]

Or, in your case, since you want to let the user know of a problem to the broswer, that execute can be written as:

  if ( !$sth->execute( $employee_number, $first_name, $last_name ) ) {
    print "Could not insert into database: ", $DBI::errstr, "\n";
    return;
  }
[download]

(or some control similar to that.)

-----------------------------------------------------
Dr. Michael K. Neylon - mneylon-pm@masemware.com || "You've left the lens cap of your mind on again, Pinky" - The Brain
"I can see my house from here!"
It's not what you know, but knowing how to find it if you don't know that's important

---

---

• Are you posting in the right place? Check out Where do I post X? to know for sure.
• Posts may use any of the Perl Monks Approved HTML tags. Currently these include the following:

  <code> <a> <b> <big> <blockquote> <br /> <dd> <dl> <dt> <em> <font> <h1> <h2> <h3> <h4> <h5> <h6> <hr /> <i> <li> <nbsp> <ol> <p> <small> <strike> <strong> <sub> <sup> <table> <td> <th> <tr> <tt> <u> <ul>

• Snippets of code should be wrapped in <code> tags not <pre> tags. In fact, <pre> tags should generally be avoided. If they must be used, extreme care should be taken to ensure that their contents do not have long lines (<70 chars), in order to prevent horizontal scrolling (and possible janitor intervention).
• Want more info? How to link or How to display code and escape characters are good places to start.