comment on

A couple of comments on your code:

You should use placeholders for values where possible for many reasons, including security, problems with quoting etc. That is you should change

    my $stmt = "SELECT * FROM $table WHERE $key_col = '$key_val'";
    my $sth = $dbhandle->prepare( $stmt );
    $sth->execute();
[download]

into

    my $stmt = "SELECT * FROM $table WHERE $key_col = ?";
    my $sth = $dbhandle->prepare( $stmt );
    $sth->execute($key_val);
[download]

You should errorcheck your database stuff. Add a || die $DBI::errstr to all your DBI->connect, $dbh->prepare and $sth->execute.

You only need two row, so only get those. That is change:

    my $ref = $sth->fetchall_arrayref();
    $sth->finish();
    return map { $_->[$name_col] => $_->[$val_col] } @$ref;
[download]

into

    my $ref = $sth->fetchall_hashref([$name_col,$val_col]);
    $sth->finish();
    return map {@$_} @$ref;
[download]

print "Content-Type: text/html\n\n"; is wrong. The HTTP standard says it should be \r\n\r\n. However most browsers dont care ;)
Dont use a & in a sub call without needing it. It overrides any prototype you may add at a later time to make perl check the number/type of params to get_hash.
Dont overgeneralize. If you only use get_hash for this specific purpose, then fill in the tablename/colname and select only the two rows you need instead of *.

T I M T O W T D I

In reply to Re: Get a hash object from a database with DBI for use with HTML::Template by Cine
in thread Get a hash object from a database with DBI for use with HTML::Template by hiseldl

Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!

Titles consisting of a single word are discouraged, and in most cases are disallowed outright.

Read Where should I post X? if you're not absolutely sure you're posting in the right place.

Please read these before you post! —

Posts may use any of the Perl Monks Approved HTML tags:

a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr

You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)

	For:		Use:
	&		`&`
	<		`<`
	>		`>`
	[		`[`
	]		`]`

Link using PerlMonks shortcuts! What shortcuts can I use for linking?

See Writeup Formatting Tips and other pages linked from there for more info.


go ahead... be a heretic
	PerlMonks