While investigating
Benchmark.pm I decided to try benchmarking different sorting algorithms, and have run into trouble with my implementation of <dfn>Merge Sort</dfn>;
sub Merge(@) {
my @array = @_;
MergeSort (0, $#array);
return @array;
sub MergeSort($$) {
my $first = shift;
my $last = shift;
if ($last>$first) {
my $mid = int(($last+$first)/2);
MergeSort($first, $mid);
MergeSort($mid+1, $last);
my @b;
@b = ( @array[$first..$mid], @array[reverse($mid+1..$last)] );
my ($i, $j, $k) = (0, $last-$first, $first);
for (; $k<=$last; $k++) {
$array[$k] = ($b[$i]<$b[$j]) ? $b[$i++] : $b[$j--];
}
}
}
}
The function works perfectly, but with warnings turned on, spits out the following:
Variable "@array" will not stay shared at ./benchmark-sort.pl line [x]
+.
Where
[x] is the first line in
MergeSort() which manipulates
@array.
Presumably I'm doing something naive here to do with the scoping of
@array, which, in slightly different circumstances, could cause errors rather than just warnings.
So, what does the warning mean, and how should I declare
@array to avoid it?
-
Are you posting in the right place? Check out Where do I post X? to know for sure.
-
Posts may use any of the Perl Monks Approved HTML tags. Currently these include the following:
<code> <a> <b> <big>
<blockquote> <br /> <dd>
<dl> <dt> <em> <font>
<h1> <h2> <h3> <h4>
<h5> <h6> <hr /> <i>
<li> <nbsp> <ol> <p>
<small> <strike> <strong>
<sub> <sup> <table>
<td> <th> <tr> <tt>
<u> <ul>
-
Snippets of code should be wrapped in
<code> tags not
<pre> tags. In fact, <pre>
tags should generally be avoided. If they must
be used, extreme care should be
taken to ensure that their contents do not
have long lines (<70 chars), in order to prevent
horizontal scrolling (and possible janitor
intervention).
-
Want more info? How to link
or How to display code and escape characters
are good places to start.