comment on

In addition to what the others said, I would also like to pint out that you can build RegExes "on the fly" and get rid of that foreach (keys ... loop in your program. I solved the original problem because it is easier ;-):

#!perl

use strict;
use warnings;

my %acronyms = (
   'HTML'    => "Hypertext Markup Language",
   'ICBM'    => "Intercontinental Ballistic Missile",
   'EEPROM'  => "Electronically-erasable programmable read only memory
+",
   'SCUBA'   => "Self Contained Underwater Breathing Aparatus",
   'FAQ'     => "Frequently Asked Questions",
   'LCARS'   => "Library Computer And Retrieval System",
   'NASA'    => "National Aeronautical and Space Administration"
);

my $regex;
{
   my $temp = join '|', map quotemeta, keys %acronyms;
   $regex = qr/($temp)/o;
}

while (<>) {
   s/$regex/$1 ($acronyms{$1})/g;
   print;
}
[download]

Anyways, you should always use strict; no matter what; it helps a lot with syntax problems.

Hope this helped.
CombatSquirrel.

Entropy is the tendency of everything going to hell.

In reply to Re: Code Optimization v5.8.1 by CombatSquirrel
in thread Code Optimization v5.8.1 by bluethundr

Are you posting in the right place? Check out Where do I post X? to know for sure.
Posts may use any of the Perl Monks Approved HTML tags. Currently these include the following:
<code> <a> <b> <big> <blockquote> <br /> <dd> <dl> <dt> <em> <font> <h1> <h2> <h3> <h4> <h5> <h6> <hr /> <i> <li> <nbsp> <ol> <p> <small> <strike> <strong> <sub> <sup> <table> <td> <th> <tr> <tt> <u> <ul>
Snippets of code should be wrapped in <code> tags not <pre> tags. In fact, <pre> tags should generally be avoided. If they must be used, extreme care should be taken to ensure that their contents do not have long lines (<70 chars), in order to prevent horizontal scrolling (and possible janitor intervention).
Want more info? How to link or How to display code and escape characters are good places to start.


Perl Monk, Perl Meditation
	PerlMonks