Hi Monks,

I am having a file named one.txt,the contents are like,

This file is having data 
It is used for authentication
Authentication number is 9
[download]

When I am running my script I get the new authentication no by @ARGV.If my new authenticaton is not equal to the authentication no found in the one.txt file,the new authentication number should be replaced inthe one.txt file.For this simple work I am using lot of lines.It looks bad for me.Let me know some other professional code to reduce my lines monks.The code is given below,

perl auth.pl 9

$argact = $ARGV[0];
open input,"one.txt";
open newfile,">output";
while(<input>){
    if($_ =~ /^Authentication\s+number\s+is/){
        @array = split(" ",$_);
        $fileid = (split(" ",$_))[3];
        if($fileid ne $argact){
            $changeflag = 1;
            pop(@array);
            push(@array,$argact);
            $newline = join(" ",@array);            
            print newfile "$newline\n";

        }else{
            print newfile "$_";
        }

    }else{
        print newfile "$_";
    }
}
[download]

Thanks and Regards,
madtoperl.

---

---

• Are you posting in the right place? Check out Where do I post X? to know for sure.
• Posts may use any of the Perl Monks Approved HTML tags. Currently these include the following:

  <code> <a> <b> <big> <blockquote> <br /> <dd> <dl> <dt> <em> <font> <h1> <h2> <h3> <h4> <h5> <h6> <hr /> <i> <li> <nbsp> <ol> <p> <small> <strike> <strong> <sub> <sup> <table> <td> <th> <tr> <tt> <u> <ul>

• Snippets of code should be wrapped in <code> tags not <pre> tags. In fact, <pre> tags should generally be avoided. If they must be used, extreme care should be taken to ensure that their contents do not have long lines (<70 chars), in order to prevent horizontal scrolling (and possible janitor intervention).
• Want more info? How to link or How to display code and escape characters are good places to start.