comment on

Since your subs all seem to take a CGI instance as an argument, you could subclass CGI.pm as Site::CGI and use that instead of CGI.pm in the top level scripts. That would help prevent putting functions with dissimilar purposes in your Common.pm.

The subclassing mechanism is not too difficult. The basic steps are:

package Site::CGI;

use CGI;
@ISA = qw/CGI/;

# subroutine definitions, object instance is first arg
# . . .

1;
[download]

Save that file as Site/CGI.pm somewhere in your @INC path.

You would then, in top level scripts, say,

use Site::CGI;  # instead of use CGI;
my $query = Site::CGI->new;

# . . .

print $query->my_sub;

# etc
[download]

After Compline,
Zaxo

In reply to Re: Converting common subroutines as a module by Zaxo
in thread Converting common subroutines as a module by sara2005

Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!

Titles consisting of a single word are discouraged, and in most cases are disallowed outright.

Read Where should I post X? if you're not absolutely sure you're posting in the right place.

Please read these before you post! —

Posts may use any of the Perl Monks Approved HTML tags:

a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr

You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)

	For:		Use:
	&		`&`
	<		`<`
	>		`>`
	[		`[`
	]		`]`

Link using PerlMonks shortcuts! What shortcuts can I use for linking?

See Writeup Formatting Tips and other pages linked from there for more info.


Just another Perl shrine
	PerlMonks