comment on

When you have to write code that reads left to right and then right to left you are trying to do two things on the same line that lacks clarity.

If I saw this in production code I would hate forever the person who wrote it.

How about this instead,

my $country = (not $card->country)    ? q{}
  :           $card->country eq 'gbr' ? q{}
  :                                     uc "[$country]";
[download]

It is only a little more verbose but it is clear at presenting the results of any specific situation.

In reply to Re: How Much Is Too Much (on one line of code)? by Herkum
in thread How Much Is Too Much (on one line of code)? by Ovid

Are you posting in the right place? Check out Where do I post X? to know for sure.
Posts may use any of the Perl Monks Approved HTML tags. Currently these include the following:
<code> <a> <b> <big> <blockquote> <br /> <dd> <dl> <dt> <em> <font> <h1> <h2> <h3> <h4> <h5> <h6> <hr /> <i> <li> <nbsp> <ol> <p> <small> <strike> <strong> <sub> <sup> <table> <td> <th> <tr> <tt> <u> <ul>
Snippets of code should be wrapped in <code> tags not <pre> tags. In fact, <pre> tags should generally be avoided. If they must be used, extreme care should be taken to ensure that their contents do not have long lines (<70 chars), in order to prevent horizontal scrolling (and possible janitor intervention).
Want more info? How to link or How to display code and escape characters are good places to start.


Just another Perl shrine
	PerlMonks