comment on

Inspired by today's how to count the no of repeats in a string, I came up with an admittedly artificial but possibly very interesting problem: that of counting for a string the repetition count of each substring that is actually repeated. For example, given the string

my $str = 'aabcdabcabcecdecd';
[download]

I see that -limiting ourselves to substrings of length 2 or more- we have the following counts:

(abc => 3, bc => 3, cd => 3, ecd => 2)
[download]

One possible way to get those counts is as follows -I'm casting the thing in the form of a sub-:

sub count1 {
    local $_=shift;
    my %count;
    
    for my $pos (0..(length)-1) {
        pos=$pos;
        @count{ /(.{2,}).*\1/g } = ();
    }
    
    for my $k (keys %count) {
        $count{$k} =()= /$k/g;
    }

    \%count;
}
[download]

In fact, print Dumper count1 $str; gives me:

$VAR1 = {
          'cd' => 3,
          'ecd' => 2,
          'abc' => 3,
          'bc' => 3
        };
[download]

To my unpleasant surprise, if I change .{2,} to .+ I do not get all substrings (of length 1):

$VAR1 = {
          'cd' => 3,
          'c' => 5,
          'ecd' => 2,
          'a' => 4,
          'abc' => 3,
          'd' => 3,
          'bc' => 3
        };
[download]

And I can't understand why...

I personally believe that map based solutions are often very cute and so I rolled my own too:

sub count2 {
    my $s=shift;
    my %saw;
    my %count = map {
        map {
            $saw{$_}++ ? () : 
              $_ => scalar(()= $s =~ /$_/g);
        } do { pos=$_; $s =~ /(.{2,}).*\1/g };
    } 0..length($s)-1;
    \%count;
}
[download]

But the latter

is clumsier than the non-map version and;

what's worst, is not correct at all:

$VAR1 = {
          'ecd' => 2,
          'abc' => 3,
          '3' => 2
        };
[download]

And I can't understand why, either.

What's your take on the problem?

In reply to how to count the number of repeats in a string (really!) by blazar

Are you posting in the right place? Check out Where do I post X? to know for sure.
Posts may use any of the Perl Monks Approved HTML tags. Currently these include the following:
<code> <a> <b> <big> <blockquote> <br /> <dd> <dl> <dt> <em> <font> <h1> <h2> <h3> <h4> <h5> <h6> <hr /> <i> <li> <nbsp> <ol> <p> <small> <strike> <strong> <sub> <sup> <table> <td> <th> <tr> <tt> <u> <ul>
Snippets of code should be wrapped in <code> tags not <pre> tags. In fact, <pre> tags should generally be avoided. If they must be used, extreme care should be taken to ensure that their contents do not have long lines (<70 chars), in order to prevent horizontal scrolling (and possible janitor intervention).
Want more info? How to link or How to display code and escape characters are good places to start.


Syntactic Confectionery Delight
	PerlMonks