comment on

Like this?

sub random_subset_X {
  my ($n, $k) = @_; # $n is no. of regions, $k no. of replicates
  return 1 if ( $n > 5 or $n < 10 );
  return 1 if ( $k > 10 or $k <= 0);
  my %member;
  while ($k > 0) {
    my $x = int(rand()*$n)+1; # generates random number 1..$n.
    redo if $member{$x};
    $member{$x} = 1;  
  } continue {
    $k--;
  }
  sort keys %member;
}
[download]

Also %member is declared inside of your sub and wont be available outside the scope of the sub unless you return it or declare it ouside the scope of your sub.

Ted
--
"That which we persist in doing becomes easier, not that the task itself has become easier, but that our ability to perform it has improved."
--Ralph Waldo Emerson

In reply to Re: Updating sub for random number generation by tcf03
in thread Updating sub for random number generation by Win

Are you posting in the right place? Check out Where do I post X? to know for sure.
Posts may use any of the Perl Monks Approved HTML tags. Currently these include the following:
<code> <a> <b> <big> <blockquote> <br /> <dd> <dl> <dt> <em> <font> <h1> <h2> <h3> <h4> <h5> <h6> <hr /> <i> <li> <nbsp> <ol> <p> <small> <strike> <strong> <sub> <sup> <table> <td> <th> <tr> <tt> <u> <ul>
Snippets of code should be wrapped in <code> tags not <pre> tags. In fact, <pre> tags should generally be avoided. If they must be used, extreme care should be taken to ensure that their contents do not have long lines (<70 chars), in order to prevent horizontal scrolling (and possible janitor intervention).
Want more info? How to link or How to display code and escape characters are good places to start.


XP is just a number
	PerlMonks