I just want to point out the potential bug that is almost always
lurking around uses of split /\s+/. If there is
leading whitespace in the string, that code will give you a null
leading element in the return list. In the case of arturo's search
routine above, if the search term passed in happens to contain a leading
space (for whatever reason), then the pattern constructed will
look like /|term1|term2|etc/ and will match on any
string (and this bug might be difficult to spot -- even if you print
out the pattern string you might not notice the leading | in the
pattern).
So, the moral is, usually when you want to split on multiple whitespace you'll
want to use the special case of just a string with a single space in
it as the first argument to split(), ie: split " ", $terms;.
(and split() with no arguments is just doing: split(" ",$_)).
A second point about your search subroutine is that you can use the
construct the pattern with the case sensitive switch embedded in the
pattern via (?i). You can also then use the qr// operator so that the
regex does not have to be recompiled for each name passed through the
grep block. So, I'd change that routine to:
sub search {
my $terms = shift;
my $pattern = join "|", split " ", $terms;
my $case = $FORM{case} eq 'insensitive'?"(?i)":"";
$pattern = qr/$case$pattern/;
my @matches = grep { /$pattern/ } @names;
return \@matches;
}
Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
Read Where should I post X? if you're not absolutely sure you're posting in the right place.
Please read these before you post! —
Posts may use any of the Perl Monks Approved HTML tags:
- a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
|
For: |
|
Use: |
| & | | & |
| < | | < |
| > | | > |
| [ | | [ |
| ] | | ] |
Link using PerlMonks shortcuts! What shortcuts can I use for linking?
See Writeup Formatting Tips and other pages linked from there for more info.
|
|