I am looking for a more efficient means of getting data from a directory of tab separated files into hash. The directory is full of files in the format: key\tvalue0\tvalue1\tvalue2\nkey\tvalue0\tvalue1\n ... the individual files are small (~10 lines) but the directory can be fairly large (10,000 files). I am sure there is a better way to do it than the way i have been, so i come to the monks to find the best way. Here is what i have been doing.

my $dir = "/Path/to/a/data/directory";
my %hash;
my @ls = `ls $dir`;
foreach (@ls){
   chomp;
   next if /\~$/ || !$_;
   my $file = $_;
   my $info = `cat $dir/$_`;
   my (@lines) = split(/\n/,$info);
   for (@lines){
       s/^\s+//; next if /^\#/ || !$_;
       my ($key, @values) = split(/\t/);
       $hash{$file}{$key} = [@values];
   }
}
[download]

if there is a better way, glob or readdir, please give an example of how i should adapt my code?

---

---

• Are you posting in the right place? Check out Where do I post X? to know for sure.
• Posts may use any of the Perl Monks Approved HTML tags. Currently these include the following:

  <code> <a> <b> <big> <blockquote> <br /> <dd> <dl> <dt> <em> <font> <h1> <h2> <h3> <h4> <h5> <h6> <hr /> <i> <li> <nbsp> <ol> <p> <small> <strike> <strong> <sub> <sup> <table> <td> <th> <tr> <tt> <u> <ul>

• Snippets of code should be wrapped in <code> tags not <pre> tags. In fact, <pre> tags should generally be avoided. If they must be used, extreme care should be taken to ensure that their contents do not have long lines (<70 chars), in order to prevent horizontal scrolling (and possible janitor intervention).
• Want more info? How to link or How to display code and escape characters are good places to start.