One things I consider viataly important when writing code, make it readable. Something that are just as valuable in perl as any other language, if not more so given the oportunity to abuse perl.

Avoid side effects, ensure that each line has a specific purpose. Try to ensure that each line performs a single operation. This will save you hours in debugging and maintenence. Likes such as:

return $v[0]->[$h].$h[!!$h].$and[!!($h&&($t||$u))].$v[!(1==$t&&($u+=10
+)&&($t=0))]->[$t].$format{'space'}.$v[0]->[$u];
[download]

Should be split into several lines. Why write the code to be so difficult to read?

All in all very clever code, VERY hard to read, consequently its worth is much reduced.
--

Zigster

---

---

• Are you posting in the right place? Check out Where do I post X? to know for sure.
• Posts may use any of the Perl Monks Approved HTML tags. Currently these include the following:

  <code> <a> <b> <big> <blockquote> <br /> <dd> <dl> <dt> <em> <font> <h1> <h2> <h3> <h4> <h5> <h6> <hr /> <i> <li> <nbsp> <ol> <p> <small> <strike> <strong> <sub> <sup> <table> <td> <th> <tr> <tt> <u> <ul>

• Snippets of code should be wrapped in <code> tags not <pre> tags. In fact, <pre> tags should generally be avoided. If they must be used, extreme care should be taken to ensure that their contents do not have long lines (<70 chars), in order to prevent horizontal scrolling (and possible janitor intervention).
• Want more info? How to link or or How to display code and escape characters are good places to start.