I am writing a little script to maintain some log files. In the nature of readability I have set up several if statements to make it easier for the folks that follow. Due to the fact that it will be run without much need for efficiency, I went for readablity.

#see if it hasn't been touched in 3 days 
 if (-M "$logdir/$f" > 3.0)          
                {
                #see if file begins with ab or def case insensitive  
                if ($f=~/^(ab|def)/i)      
                        {
                        #see if hasn't been zipped already 
                        if (!($f=~/gz\b/)) 
                                {
                                system ("/usr/local/bin/gzip", "$logdi
+r/$f");
                                }
[download]

My question would be would it be more efficient to have a larger regex that does it in one pass?

---

---

• Are you posting in the right place? Check out Where do I post X? to know for sure.
• Posts may use any of the Perl Monks Approved HTML tags. Currently these include the following:

  <code> <a> <b> <big> <blockquote> <br /> <dd> <dl> <dt> <em> <font> <h1> <h2> <h3> <h4> <h5> <h6> <hr /> <i> <li> <nbsp> <ol> <p> <small> <strike> <strong> <sub> <sup> <table> <td> <th> <tr> <tt> <u> <ul>

• Snippets of code should be wrapped in <code> tags not <pre> tags. In fact, <pre> tags should generally be avoided. If they must be used, extreme care should be taken to ensure that their contents do not have long lines (<70 chars), in order to prevent horizontal scrolling (and possible janitor intervention).
• Want more info? How to link or How to display code and escape characters are good places to start.