comment on

Hi,
here are two almost identical pieces of catalyst code. I'm not sure which way preferred/more readable. Any comments, suggestions?

sub edit : Chained('object') : PathPart('edit') : Args(0) : FormConfig
+('ticker/edit.yml') {
    my ( $self, $c ) = @_;

    $c->stash->{form}->model->default_values( $c->stash->{object} );

    if ( $c->stash->{form}->submitted_and_valid ) {
        $c->stash->{form}->model->update( $c->stash->{object} );
        $c->response->redirect( $c->uri_for( $c->controller('Ticker')-
+>action_for('index') ) );
        $c->detach;
    }
    $c->stash( template => 'ticker/edit.tt2' );
}
[download]

sub edit : Chained('object') : PathPart('edit') : Args(0) : FormConfig
+('ticker/edit.yml') {
    my ( $self, $c ) = @_;

    my $form   = $c->stash->{form};
    my $ticker = $c->stash->{object};

    $form->model->default_values($ticker);

    if ( $form->submitted_and_valid ) {
        $form->model->update($ticker);
        $c->response->redirect( $c->uri_for( $c->controller('Ticker')-
+>action_for('index') ) );
        $c->detach;
    }
    $c->stash( template => 'ticker/edit.tt2' );
}
[download]

Thanks

In reply to Coding style by nyamned

Are you posting in the right place? Check out Where do I post X? to know for sure.
Posts may use any of the Perl Monks Approved HTML tags. Currently these include the following:
<code> <a> <b> <big> <blockquote> <br /> <dd> <dl> <dt> <em> <font> <h1> <h2> <h3> <h4> <h5> <h6> <hr /> <i> <li> <nbsp> <ol> <p> <small> <strike> <strong> <sub> <sup> <table> <td> <th> <tr> <tt> <u> <ul>
Snippets of code should be wrapped in <code> tags not <pre> tags. In fact, <pre> tags should generally be avoided. If they must be used, extreme care should be taken to ensure that their contents do not have long lines (<70 chars), in order to prevent horizontal scrolling (and possible janitor intervention).
Want more info? How to link or How to display code and escape characters are good places to start.


go ahead... be a heretic
	PerlMonks