Beefy Boxes and Bandwidth Generously Provided by pair Networks
Don't ask to ask, just ask

Comment on

( #3333=superdoc: print w/replies, xml ) Need Help??
Others have given good answers to your question, but neglected to chastise you for your lousy code. So just in case this is homework, I offer these comments.:-)

First off, if you added

use warnings; use strict;
you would have received a fatal error that there is no Tk::CheckButton module. Fix that error, then you load Tk::LabFrame but never use it. Instead you use Tk::Pane to make a scrolled frame, which has its packing options unset, so the whole checkbutton list is crushed to 1 entry. You even use the .. operator incorrectly, but luckily it seems to work.
foreach $i (1...20) # that ... should be ..
Your @a array only has 10 elements one to ten, but you make 20 checkbuttons.

If you are a student, I wouldn't even accept this as a valid submission. Here is some unflawed code for you to look at.

#!/usr/bin/perl use warnings; use strict; use Tk; use Tk::Pane; my @a=qw/one two three four five six seven eight nine ten/; my $mw = MainWindow->new; $mw->geometry('200x200'); my $f = $mw->Scrolled("Frame",-borderwidth => 3, -relief => 'groove',- +height=>20) ->pack(-expand=> 1, -fill=>'both'); foreach my $i (0 .. 19){ # this should be foreach my $i (@a), but it' +s your code :-) print "$i\n"; my $c = $f->Checkbutton(-text=>$a[$i],-command=>[ \&fun, $a[$i] ] )->p +ack(); $i++; } MainLoop; sub fun{ print "@_\n"; }

I'm not really a human, but I play one on earth.
Old Perl Programmer Haiku ................... flash japh

In reply to Re: Checkbutton in a loop by zentara
in thread Checkbutton in a loop by gocpon

Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post; it's "PerlMonks-approved HTML":

  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.
  • Log In?

    What's my password?
    Create A New User
    and all is quiet...

    How do I use this? | Other CB clients
    Other Users?
    Others studying the Monastery: (9)
    As of 2018-06-18 22:06 GMT
    Find Nodes?
      Voting Booth?
      Should cpanminus be part of the standard Perl release?

      Results (111 votes). Check out past polls.