Your solution is an excellent use of a HoH! Here are a few items to consider within your foreach:
foreach (@ARGV) {
open my $fh, '<', $_ or die $!;
while ( my $line = <$fh> ) {
next unless my @p = $line =~ /^(chr.+?)\t+(\d+)\t+(\d+)/;
$minmax{ $p[0] }{min} //= $p[1];
$minmax{ $p[0] }{max} //= $p[2];
if ( $p[1] < $minmax{ $p[0] }{min} ) {
$minmax{ $p[0] }{min} = $p[1];
}
if ( $p[2] > $minmax{ $p[0] }{max} ) {
$minmax{ $p[0] }{max} = $p[2];
}
}
close $fh;
}
- A three-argument open is used
- A lexically-scoped variable is used for the file handle
- or die $! checks for open errors
- The regex line:
- Skips possible comment and track definition lines in the BED files
- And then makes using chomp and split unnecessary
- Uses defined-or-equals (//=) to replace the !exists
Hope this is helpful.
-
Are you posting in the right place? Check out Where do I post X? to know for sure.
-
Posts may use any of the Perl Monks Approved HTML tags. Currently these include the following:
<code> <a> <b> <big>
<blockquote> <br /> <dd>
<dl> <dt> <em> <font>
<h1> <h2> <h3> <h4>
<h5> <h6> <hr /> <i>
<li> <nbsp> <ol> <p>
<small> <strike> <strong>
<sub> <sup> <table>
<td> <th> <tr> <tt>
<u> <ul>
-
Snippets of code should be wrapped in
<code> tags not
<pre> tags. In fact, <pre>
tags should generally be avoided. If they must
be used, extreme care should be
taken to ensure that their contents do not
have long lines (<70 chars), in order to prevent
horizontal scrolling (and possible janitor
intervention).
-
Want more info? How to link
or How to display code and escape characters
are good places to start.
|