That's the second comment like that that I got (well, first for this version). Both with no explaination. I'll ignore it. | [reply] |
I will attempt to recap my conversation with you about these matters after the May weekend has concluded. Be sure, I did talk with you about this in the chatterbox at least twice. I will quickly note that you are using globals in an unsafe manner, system calls without checking for failure, and parsing perl. I recall raising more issues but I don't recall them at the moment. Oh yes. It was also a disagreement with the purpose of the code. reset() is something meant more for perl4 code where we didn't have my(). Common best (or even mediocre to poor) practice uses my() to properly handle the issues you are attempting to handle by continuing in the perl4 idiom.
| [reply] |
Ok, we'll finish this after the weekend.
Till then, I don't see how my use of globals is unsafe. If my use of eval could end up doing something dangerous because I'm improperly parsing the code before evaling it, please explain. I reviewed my code after you warned me about that, but I couldn't find a problem.
"or die" is a good idea, if that's what you meant by checking for failure, but that's a 30 second job that should be taken care of, rather than something to make me forget about the script. I'll be adding other error reporting as well.
Parsing Perl isn't bad. Even if it's not as robust as another method, it's not bad. If the script would fail too often, that's bad, but you didn't explain how.
Nobody has to use the reset function of my script, but the fact remains that not all variables in some good scripts are "my" variables, and sometimes those all need to be reset. I believe I have such a script (not VarStructor, which could use my, but I don't see why it's important).
| [reply] |
