Beefy Boxes and Bandwidth Generously Provided by pair Networks
Your skill will accomplish
what the force of many cannot

Re: Style or Clarity?

by sgifford (Prior)
on Jun 08, 2004 at 20:29 UTC ( #362535=note: print w/replies, xml ) Need Help??

in reply to Style or Clarity?

If you're concerned that the clearer version should be slower, you should benchmark it:
#!/usr/bin/perl -w use strict; use Benchmark; sub clarity { my $tmp = shift; my $ret = 0; if($tmp eq 'F'){ ; # do nothing, spot held for clarity }elsif($tmp =~ /[MICL]/){ $ret = 1; }else{ $ret = 2; } return $ret; } sub speed { my $tmp = shift; my $ret = 0; if($tmp =~ /[MICL]/){ $ret = 1; }else{ $ret = 2; } return $ret; } timethese(100_000, { clarity => sub { clarity('F'); clarity('M'); clarity('J'); }, speed => sub { speed('F'); speed('M'); speed('J'); }, } );
Benchmark: timing 100000 iterations of clarity, speed... clarity: 2 wallclock secs ( 1.74 usr + 0.00 sys = 1.74 CPU) @ 57 +471.26/s (n=100000) speed: 2 wallclock secs ( 1.78 usr + 0.00 sys = 1.78 CPU) @ 56 +179.78/s (n=100000)

So it appears that, at least in this test, the clearer version is a little faster. Your tests can simulate your environment better, but it looks like both chunks of code are really close to the same speed, and you should code however you find most clear and enjoyable. :)

Update: Abigail-II's right, this benchmark is a little off, and in fact a first attempt to correct it makes speed slightly faster, though it's still within a few percent. Still, you can easily see how to modify this to benchmark your actual functions and see if there is enough of a speed difference to sacrifice clarity.

Replies are listed 'Best First'.
Re: Style or Clarity?
by Abigail-II (Bishop) on Jun 09, 2004 at 12:24 UTC
    Considering that clarity ('F') returns 0, and speed ('F') returns 2, I don't think the benchmark is valid.


Log In?

What's my password?
Create A New User
Node Status?
node history
Node Type: note [id://362535]
and the web crawler heard nothing...

How do I use this? | Other CB clients
Other Users?
Others romping around the Monastery: (6)
As of 2020-11-27 09:42 GMT
Find Nodes?
    Voting Booth?

    No recent polls found