extract substring between token a and token b

[philosophia]

hi

i'm trying to extract $substring from $text - where $text is a block of html and $substring is anything between

<!--begin--> and
<!--/end-->

in $text.

i've tried

$text =~ /%<\!--begin-->%(.*?)%<\!--end-->/;
$substring = $1;
print $substring;


but this doesn't seem to be working. i'm not sure if my regex is right first of all. also, is there any way to do this without using the global variable $1?

thanks

[LassiLantar]

This works... I'm not sure what the "%"s in your regex were for.

#!/usr/bin/perl

$text = "<!--begin-->this is a line of text<!--end--><!--begin-->anoth
+er one<!--end-->";

@lines = $text =~ /<\!--begin-->(.*?)<\!--end-->/g;
foreach (@lines) {
  print $_ . "\n";
}

Peace!
LassiLantar

[itub]

If the string you want to match spans more than one line, you need to use the /s modifier, because otherwise the dot doesn't match the newline character.

If you do the pattern matching in list context with the /g (global) option, you can capture all the matches in one array without using $1. e.g., @matches = $text =~ /(pattern)/g;

[philosophia]

you guys are awesome thanks

[revdiablo]

Your question has been directly answered, but there is a major pitfall to your approach. Even using the non-greedy match, you will run into problems with nested tags. Example:

    $input = '<foo>bar<foo>oops</foo></foo>';
    print $input =~ m{<foo>(.*?)</foo>}, "\n";

    __OUTPUT__
    bar<foo>oops

This is one big reason you should avoid simple regular expressions for parsing nested formats, like HTML. The best solution is to use a real parser that actually understands its source data, rather than simple pattern matches.