Re: Including files

This is an archived low-energy page for bots and other anonmyous visitors. Please sign up if you are a human and want to interact.

You probably want to fix this:

my $code = join(
    "\n",
    qq[#line 1 "$filename"],
    File::Slurp::read_file($filename)
);
[download]

You provide list context to read_file, only to then glue all the lines back together anyway. Except that you didn't chomp them, so joining with \n doubles all EOLs which throws off your line numbers. You want a simple concatenation instead.

my $code = qq[#line 1 "$filename"\n] . File::Slurp::read_file($filenam
+e);
[download]

Very nice work on the node.

Makeshifts last the longest.

Comment on Re: Including files Select or Download Code

Replies are listed 'Best First'.

Re^2: Including files
by Juerd (Abbot) on Sep 26, 2004 at 16:24 UTC

You provide list context to read_file, only to then glue all the lines back together anyway.

Oops. That join is a left over bit of an earlier, more complex, attempt. Because Perl doesn't care about double newlines, and I didn't test with multi-line strings, and haven't even looked at line numbers, I never noticed that anything was wrong.

You are of course right that simple concatenation is better here. I'll update the node right away.

Juerd # { site => 'juerd.nl', plp_site => 'plp.juerd.nl', do_not_use => 'spamtrap' }

[reply]

• hippo

‥ epoptai's answer Re: how do I set a cookie and redirect was blessed by hippo!

• erzuuli

‥ Anonymous Monks are no longer allowed to use Super Search, due to an excessive use of this resource by robots.


We don't bite newbies here... much
	PerlMonks