The bigger problems you have with re-inventing wheels that should not be reinvented notwithstanding, your main problem is the fundamentally broken loop that is looking at the data that came from the file. Without resorting to rewriting code for you, in english your program does this:
- Open $logpath and read in the contents
- Iterate through the lines found there, and
- If the browser in this line is the one from the form, increment it's counter and print it to the log
- If the browser in this line is not the one from the form, print it to STDOUT
In a nutshell, this means that the browser that matches the form entry gets printed to the log, while the others get printed to the browser. I bet if you looked at the logfile, you would find it always contains at most 1 line.
There are however, several other problems with this code:
- Always, Always, Always use '-w' and 'use strict'.
- Doing your own parameter parsing instead of using CGI is just asking for trouble.
- Not checking the return code from your open calls means you may be truncating your logfile to rewrite it, even though the script didn't read any data from it in the first place.
- Not handling locking means that if two people submit the form at the same time, your logfile could very likely be nuked by the second one.
| We're not surrounded, we're in a target-rich environment! |
|---|
