Beefy Boxes and Bandwidth Generously Provided by pair Networks
Your skill will accomplish
what the force of many cannot
 
PerlMonks  

Re: Complex Data Structure Suggestions Wanted

by thcsoft (Monk)
on Jun 07, 2005 at 11:19 UTC ( #464239=note: print w/replies, xml ) Need Help??


in reply to Complex Data Structure Suggestions Wanted

the if... else can be expressed a bit more elegantly:
@{$HashRef->{$ItemId}} ||= []; push @{$HashRef->{$ItemId}}, $DataSource;
apart from that: the notation of variable names you chose is not perlish. in perl you mix capital and small letters only for class names: package MyClass; vs:  my $hash_ref;

language is a virus from outer space.

Replies are listed 'Best First'.
Re^2: Complex Data Structure Suggestions Wanted
by Ninthwave (Chaplain) on Jun 07, 2005 at 13:44 UTC

    Thank you for the help.

    I will have to disagree with you on variable naming convention though. Because perl does not have a rule for variable naming conventions in the language and this is internal code I use a convention that helps me explain what the variable is quickly. I use multiple words that describe the data as exact as possible. I use capitals to keep multiple words from blurring instead of underscores. Now if I wanted this to be a module for CPAN I would use the perl style guide. And I would simplify the variables to be few and one worders, so all lowercase.

    And I do have comments to explain variable so this is a bit overkill but when you are staring at chunks of code a good variable name will save you the second window that is stuck at your table of variable definitions.

    But I think this would be more of a meditation than a discussion on a question.


    "No matter where you go, there you are." BB

Log In?
Username:
Password:

What's my password?
Create A New User
Node Status?
node history
Node Type: note [id://464239]
help
Chatterbox?
and the web crawler heard nothing...

How do I use this? | Other CB clients
Other Users?
Others avoiding work at the Monastery: (10)
As of 2020-12-01 22:02 GMT
Sections?
Information?
Find Nodes?
Leftovers?
    Voting Booth?
    How often do you use taint mode?





    Results (23 votes). Check out past polls.

    Notices?