Beefy Boxes and Bandwidth Generously Provided by pair Networks
The stupid question is the question not asked
 
PerlMonks  

Re^8: Test::More and is_array

by geektron (Curate)
on Jun 13, 2005 at 15:14 UTC ( [id://466193]=note: print w/replies, xml ) Need Help??


in reply to Re^7: Test::More and is_array
in thread Test::More and is_array

well, calling the routine in question gives me the correct list, so i just need to check and make sure that it's populated.

Replies are listed 'Best First'.
Re^9: Test::More and is_array
by adrianh (Chancellor) on Jun 16, 2005 at 22:30 UTC
    well, calling the routine in question gives me the correct list, so i just need to check and make sure that it's populated.

    I'm probably misunderstanding, but....

    If you know it is the correct list, why do you need to check if it's populated?

    Wouldn't it be better to check for the correct list being returned anyway? Even if you are 100% certain that the current code works, you might break something later on and a more concrete test will catch that.

    Isn't a more concrete is_deeply() test is simpler to write?

      i'm being ... overly paranoid because of the huge changes to the underlying database structure.
        i'm being ... overly paranoid because of the huge changes to the underlying database structure.

        Fair enough, but to my eyes your proposed tests:

        my $list = $object->foundation_list; ok( ref( $list ) eq 'ARRAY', 'returned a list' ); ok( scalar( @$list ), 'returned a populated list' ); ok( ref( $list->[0] ) eq 'HASH', 'first element is a hashref ...' );

        are less paranoid than the more concrete test:

        is_deeply( $object->foundation_list, [ { ... whatever ... } ] );

        It does all the type checking and makes sure it's been populated with the correct values.

Log In?
Username:
Password:

What's my password?
Create A New User
Domain Nodelet?
Node Status?
node history
Node Type: note [id://466193]
help
Chatterbox?
and the web crawler heard nothing...

How do I use this?Last hourOther CB clients
Other Users?
Others lurking in the Monastery: (3)
As of 2024-04-25 12:51 GMT
Sections?
Information?
Find Nodes?
Leftovers?
    Voting Booth?

    No recent polls found