Beefy Boxes and Bandwidth Generously Provided by pair Networks
more useful options
 
PerlMonks  

Re^2: On bad habits

by Nkuvu (Priest)
on Jun 21, 2005 at 16:38 UTC ( #468746=note: print w/replies, xml ) Need Help??


in reply to Re: On bad habits
in thread On bad habits

Funny, I'm just the opposite. I make my code too lengthy and comment too much.

I used to have the bad habit of while (chomp(my $line = <INPUT>)) but a few gasps from some monks cured me of that. Amazing what even minimal peer review can do for coding practices.

Replies are listed 'Best First'.
Re^3: On bad habits
by tlm (Prior) on Jun 21, 2005 at 17:02 UTC

    But just to clarify, the biggest problem with that code fragment is not that it's lengthy, but that it discards the last line of the file when it does not end in a $/.

    the lowliest monk

      Exactly. And this is something that I never realized until someone pointed it out to me (just never really thought about it). I was fortunate enough to never have this bite me, and got out of the habit of the fragment before it did actually cause problems.
Re^3: On bad habits
by perrin (Chancellor) on Jun 21, 2005 at 17:12 UTC
    Verbose is fine, if it's clear and easy to read. Don't let people tell you that you must use $_ just because it's there.
      I don't have any good examples of my old bad code. But I'm referring to comments on how the Perl code is working when it is totally unnecessary. Comments like
      # Make '3' into '03' $some_value = sprintf "%02d", $some_value;
      or perhaps code snippets where it can easily be reduced -- note that this is a contrived example, because I tend to collapse my conditionals if possible (and have for a very long time). But still it illustrates my point:
      my $time = localtime(); if ($time =~ /^Tue/i) { if ($time =~ /2005$/) { print "It's some Tuesday in 2005\n"; } }

Log In?
Username:
Password:

What's my password?
Create A New User
Domain Nodelet?
Node Status?
node history
Node Type: note [id://468746]
help
Chatterbox?
and the web crawler heard nothing...

How do I use this? | Other CB clients
Other Users?
Others surveying the Monastery: (1)
As of 2021-10-23 13:48 GMT
Sections?
Information?
Find Nodes?
Leftovers?
    Voting Booth?
    My first memorable Perl project was:







    Results (88 votes). Check out past polls.

    Notices?