Re: everyauction script error bidding errors

[mkmcconn]

simonwilliams, you wrote,

if($#bids){
  for (my $i = $#bids; $i > 1; $i = 1) {
    ...
  }
}

Where I'm pretty sure that what you meant was,

if (@bids > 1){
  for (my $i = 0; $i <= $#bids; $i++) {
    ...
  }
}

But, many of us would prefer to write this as:

if (@bids > 1){
  for my $bid (@bids){
    my ($alias, $email, $bid, $time, $add1, $add2, $add3) = readbid($b
+id);
  }
}

You also wrote,

  $time = sort ({ int $a <=> int $b } $time);

This will not do anything. $time is not a LIST. See perldoc -f sort;

By the way, you'll get better answers if you work harder on distilling your question to one essential issue. Hope all this helps, and welcome to the Monastery.
mkmcconn

[simonwilliams]

If i replace the code with this;

my $lowest_new_bid;

    if ($#bids) {

        for (my $i=1; $i<scalar(@bids); $i++) {

    my ($alias, $email, $bid, $time, $add1, $add2, $add3, $oqty, $sold
+qty) = &read_bid($bids[$i]);

    if (($form{'ALIAS'} ne $lastbid[0]) && ($form{'ALIAS'} eq $alias))
+ {
    if (($form{'ALIAS'} ne $firstbid[0]) && ($form{'ALIAS'} eq $alias)
+) {

it works but it now prints all the bids the user has placed on the item and i need it to only display the highest last placed bid but under the current high bid of the highest bidder.

[mkmcconn]

simonwilliams,

1.    if ($#bids){...}
   does what you mean, but it doesn't really say what you mean. For that, you should say
      if (@bids > 1){ ... };
   i.e., if @bids contains more bids than one, then ...
2.   for (my $i=1; $i<scalar(@bids); $i++) { ... }
   could be written ...
     for (my $i=1; $i < @bids; $i++) { ... }
   ... without any change in meaning. @bids is being evaluated in a scalar context. No need to say scalar() explicitly.
3. Let me oversimplify your problem, and you can build on that. You want to choose the highest bid, excluding your own from consideration (always the first bid), and print only the highest bid.

   my $highest;
   if (@bids > 1){
       for (my $i = 1; $i < @bids; $i++) {
           my ($alias, 
               $email, 
               $bid, 
               $time, 
               $add1, 
               $add2, 
               $add3, 
               $oqty, 
               $soldqty) = read_bid($bids[$i]);
           $highest = $bid > $highest ? $bid : $highest;
       }
       print "Highest bid: $highest\n";
   }
   


mkmcconn