|There's more than one way to do things|
Re^3: popping, shifting or splicing an array???by injunjoel (Priest)
|on Aug 11, 2005 at 20:00 UTC||Need Help??|
Okay so maybe the hash in not in order but I have a few questions about your current approach.
Since you are allowing for multiple selections in your scrolling_list
if the user selected four elements from random places in the list then the first five values are clipped from the list, four times. Not the elements the user selected.
It seems like each time through your foreach (hypothetically four times) you clip the the elements in @H99tapes from 0 to $tape_count (in this case 4) so five elements are removed from the beginning of the array. Also by replacing the missing values with the entire list again you are increasing the size of your list almost exponentially, at least by a factor of scalar(@H99tapes) - (scalar(@tape_imports) + 1). In a test I ran with your code and four random values the resulting size of @H99tapes was 15252! Its starting size was 957.
The impetus behind my hash suggestion was that you could use the map to remove those elements with the same value as those the user selected rather than trying to manipulate the list based on positional index, however looking at your code a hash is not in order, yet the logic still is. So it seems like you would want to remove those values stored in @tape_imports from the @H99tapes list. In that case you could use the first example from my previous post.
Does that makes sense? Or am I not getting it? I think splice might not be what you are looking for since it deals with postional indexing rather than element values. You would need to know what postions in your @H99tapes array the user selected elements are at in order to accurately splice them out. Since map returns a list we can just re-write the @H99tapes array with a grep call to filter out unwanted values, regardless of position.
"I do not feel obliged to believe that the same God who endowed us with sense, reason and intellect has intended us to forego their use." -Galileo