Re: A refactoring trap

[Albannach]

One of my personal rules: Always question a rule that starts with always.

While I agree that /x can be mighty handy, I think that your case is so simple as to be made less clear by the change. Perhaps this is because I am used to certain regex idioms, or I just don't like your choice of braces, but I would have thought your first version was better, apart from the explict use of $line which is an improvement.

Well the best thing about opinions is that you can always get another.