Re: passing number of files in directory to subroutine

Besides making your code more Perlish (as GrandFather said, but I'd use / instead of \\), I think the problem is in your Calc subroutine...

Anyway, the code doesn't make much sense: What order do you expect the file to be in @onedir and @twodir? You'll have to do something with them to get the right order! Maybe something as:

my @onedir = sort grep !/^\./ readdir DIR1
[download]

Paul

Comment on Re: passing number of files in directory to subroutine Select or Download Code

Replies are listed 'Best First'.
Re^2: passing number of files in directory to subroutine by GrandFather (Saint) on Sep 23, 2005 at 11:34 UTC
I agree wrt / versus \\ - that's my C/Windows background shining through again :). Pretty sure the original problem was the missing / however. I also think you are correct raising the issue of the file orders in the two arrays. Most OS's don't guarantee the order that files are stored in a dir and you can be pretty sure it won't be alphabetical for example. OP may be wise to sort the arrays before he uses them if the pairing order is important. Perl is Huffman encoded by design.	[reply]
Re^3: passing number of files in directory to subroutine by Angharad (Pilgrim) on Sep 23, 2005 at 11:45 UTC
Hi. Your code worked a treat, thanks Grandfather. As regards to the ordering of the arrays .. advice duly noted. In this case, the files are called something along these lines: `nameoffile012298.txt` [download] etc .. so for one file in one directory there is a corresponding file with the exact same name and number in the other directory. Seems to be working without the need for sorting right now but I shall be watchful :)	[reply] [d/l]
Re^2: passing number of files in directory to subroutine by Angharad (Pilgrim) on Sep 23, 2005 at 11:08 UTC
OK, but I thought that if it the data was in a array the order was the same as whwn you added the values in. (unlike hashes which I know are 'unordered'). There is nothing wrong with the Calc routine by the way .. that has been throughly tested.	[reply]
Re^3: passing number of files in directory to subroutine by rev_1318 (Chaplain) on Sep 23, 2005 at 11:47 UTC
I thought that if it the data was in a array the order was the same as whwn you added the values in Yes, but the order in which the files are added to your array are not by default in alphabetic order. Most of the time, you get then in a different order, e.g. based on inode. Paul	[reply]


No such thing as a small change
	PerlMonks