Beefy Boxes and Bandwidth Generously Provided by pair Networks
The stupid question is the question not asked

Re (tilly) 1: Anything

by tilly (Archbishop)
on Jan 11, 2001 at 19:37 UTC ( #51128=note: print w/replies, xml ) Need Help??

in reply to Anything

I voted --, and wanted to explain why.

Given all of the fuss over handrolled CGI parsers lately, I am amazed that you would post your own. chromatic right now has an excellent explanation of why you really didn't want to do that. (And yes, you did make most of the common mistakes.)

Additionally you don't seem to be aware of a variety of race conditions, security holes, etc. For a random instance take a look at this and figure out how many of the attacks you could be taken down with. Oh, better than that, how many of the attacks are designed to get around checks that you don't even do?

Hopefully you will take this as constructive criticism and learn how to avoid these problems in the future. But in the meantime -- for bad advice that will put at risk anyone who follows it.

Replies are listed 'Best First'.
Re: Re (tilly) 1: Anything
by strredwolf (Chaplain) on Jan 11, 2001 at 23:06 UTC
    Thanks for the comments. I was looking for them, too!

    Yep, it's unfortunately handrolled, I'm a little bit spooked by's complexity. Sheesh, I just need to get varibles, not wrap the entire HTML generation process!!! (Update through the chatterbox: is split and autoloads what's needed. *sigh* Thanks, Fastolfe)

    It's also crude code, ment for an end-user; but securing it's probably worthy of some time.


Log In?

What's my password?
Create A New User
Node Status?
node history
Node Type: note [id://51128]
[choroba]: Corion A colleague has helped me. It seems the "Modification of read-only value" was caused by old Test::More version which doesn't have done_testing, plus the old bug with $@ sometimes showing a different exception
[choroba]: will upload a fixed version and see
[Corion]: choroba: Ah, OK - sounds like a really weird combination :)

How do I use this? | Other CB clients
Other Users?
Others avoiding work at the Monastery: (7)
As of 2018-06-25 14:14 GMT
Find Nodes?
    Voting Booth?
    Should cpanminus be part of the standard Perl release?

    Results (126 votes). Check out past polls.