Getting and saving IPMI Infos

[theroninwins]

Hi Monks,

here is a little problem: I am using the ipmitool to get some infos of a hardware device.
The printout is like:
CPU 1 |3000 RPM |ok
Power Supply |unspecified |cr

and so on
I need it to be
CPU1=3000RPM=ok
Power Supply=unspecified=cr

foreach $line(@saved)
{
        $tmp=s/\|/\=/,$line;
        @sort=$tmp;
}
open OUTPUT, ">>ipmiinfo.txt";
print OUTPUT @sort, "\n";
close OUTPUT;

I read the lines into @saved (that works) but the rest doesn't and it overwrites the lines aas well.

Does anyone have an idea how to sort this one out?

[Melly]

You have three problems in your script

1. "$tmp=s/\|/\=/,$line;" I've no idea what $tmp and $line will do in this context, but you are neither checking $line nor assigning to $tmp - use =~ if you are not running a regex against $_ - and $tmp is superfluous
2. You will need to use the 'g' (global) modifier, otherwise you will only change the first occurence of '|'
3. If you want to get rid of spaces (as you seem to imply), then you will need to include this in your regex

$saved[0] = 'CPU 1 |3000 RPM |ok';
$saved[1] = 'Power Supply |unspecified |cr';

open OUTPUT, ">>ipmiinfo.txt";
foreach $line(@saved){
  $line =~ s/\s*\|\s*/\=/g;
  print OUTPUT "$line\n";
}
close OUTPUT;

[theroninwins]

Thanks for the help. Indeed I want to get rid of the spaces.

[timos]

What's wrong with

foreach (@saved) {
    s/|/=/;
    push @sort, $_;
}
...

[chargrill]

Or...

@sort = map { s/ |/=/ } @saved;