Beefy Boxes and Bandwidth Generously Provided by pair Networks
Think about Loose Coupling

Re: Samba-LDAP Developer Release

by idsfa (Vicar)
on Mar 24, 2006 at 00:03 UTC ( #538906=note: print w/replies, xml ) Need Help??

in reply to Samba-LDAP Developer Release

I stopped reading at this part in Samba::LDAP:

if ( $self->{ldapTLS} == 1 ) { $ldap_master->start_tls( verify => $self->{verify}, clientcert => $self->{clientcert}, clientkey => $self->{clientkey}, cafile => $self->{cafile}, ); } $ldap_master->bind( $self->{masterDN}, password => $self->{masterP +w}, );

Please, please, please confirm that the requested TLS connection worked before you send a Domain Admin privileged account and password over the connection. The needed code looks like:

$ladp_master->code && die "failed to start TLS: ", $ldap_master->e +rror ;

The same holds true for the _slave function.

Updated: Okay I read some more. I'm twitching about:

if ($homedir) { my @rmargs = ('-rf'); # print "rm @rmargs $homedir\n"; system( 'rm', @rmargs, $homedir ); }

in Samba::LDAP::User. So many possible values of $homedir lead to ruin.

In general, there appears to be a lot of shelling out functionality that could be done in pure perl.

The intelligent reader will judge for himself. Without examining the facts fully and fairly, there is no way of knowing whether vox populi is really vox dei, or merely vox asinorum. — Cyrus H. Gordon

Replies are listed 'Best First'.
Re^2: Samba-LDAP Developer Release
by ghenry (Vicar) on Mar 24, 2006 at 07:15 UTC

    Thanks for taking the time to read some of it idsfa.

    Like I said, I haven't really touched/cleaned up any of the original code. The above isn't mine, all I have done so far is split everything up into classes and move things to methods.

    I saw the above right away too, but in the next release, things like this will be re-written and removed.

    Thanks though.

    Walking the road to enlightenment... I found a penguin and a camel on the way.....
    Fancy a Just ask!!!

Log In?

What's my password?
Create A New User
Node Status?
node history
Node Type: note [id://538906]
and all is quiet...

How do I use this? | Other CB clients
Other Users?
Others examining the Monastery: (7)
As of 2018-06-18 12:13 GMT
Find Nodes?
    Voting Booth?
    Should cpanminus be part of the standard Perl release?

    Results (109 votes). Check out past polls.