Re: Am I smoking Crack?

[Adam]

Yes.

That is a great example of poor programing style. Remember, "White space is cheap" and then try something like:

if( $2 eq "No" and $3 eq "F" )
{
    $failed = 1;
    $failed_job = $1;
    last LOOP;
}

[thor]

I'll be the first to admit that I have "poor style" as it were. I code the way I think. In my mind, I see "I want $failed to equal 1, $failed_job = $1, and exit the LOOP if $2 is No and $3 is F", so that's exactly what I wrote. My philosophy is "whatever works". Also, I think that both yours and mine are equally ok. It just depends on what you are looking for. In my case, I wanted it to be easy for someone reading the code to find conditions which $failed was 1. In your example, it would be easier to see what happens when $2 eq "No" and $3 eq "F". Thanks to all who replied, thor