Replacing backticks with system() and redirecting STDERR to file

[siva_kumar25]

Hi Monks,

Currently I am facing a problem in the below perl one liner code which is present in a perl script. 1) In this i would like to replace that "`"(backticks) with system() so that i can capture the status of the command and also would like to redirect the STDERR to the ssh'd node. Other parts of the code working fine. I have error only this part of the code.

my $command = 'ssh '. $node . ' "perl -e \'while (<>) { chomp; \$_ =~ 
+/(.*)\\//; \`su xxx -c \"mkdir -p \$1\"\`; \`su xxx -c \"touch \$_\"\
+`;}\' 1>>$storageRootPath_log 2>>$storageRootPath_err"';

my $pid = open ( $sshNodeStdinHandle{$node} , "| $command 2>>sivakumar
+" ); #SK004

print {$sshNodeStdinHandle{$node}} /x/y/z/sample.txt,"\n";

2) If $storageRootPath_log is replaced with actual path, it's working fine. But if i use path assigned to the variable $storageRootPath_log ($storageRootPath_log = '/x/y/a/log.txt'), it is not working. I spent the whole day in this issue (tried by escaping double quotes etc.), but i could not able to solve. So can you peopel please help me to resolve this issue.

Thanks & Regards,
R.Sivakumar

[gaal]

Take a look at IPC::Run for this kind of thing in general. Or specifically for SSH, look at Net::SSH.

[jettero]

That's a little confusing to read, but it looks like you can exploit the 4-arg usage of open(): FILEHANDLE,MODE,EXPR,LIST. The reason it'll help is that you don't need to escape anything. I'm not 100% on that, but I'm pretty sure open will do a popen() directly when you use this format (rather than forking to a shell first). The docs do state that it may not work like I expect on all platforms.

open $sshNodeStdinHandle{$node}, "|-", "ssh", $node, qq(perl -e ......
+..) 
    or die "couldn't open pipe: $!";

I'm pretty sure open doesn't return a pid, so I hope that isn't a problem. Otherwise you might need to look at IPC::Open3 or the like. UPDATE: It really does return a pid, but it's the pid of the shell for the two arg open and the pid of the process for the 4 arg version. Strange. I don't think that's documented, so I wouldn't count on it, but that's interesting anyway.

[bart]

my $command = 'ssh '. $node . ' "perl -e \'while (<>) { chomp; \$_ =~ /(.*)\\//; \`su xxx -c \"mkdir -p \$1\"\`; \`su xxx -c \"touch \$_\"\`;}\' 1>>$storageRootPath_log 2>>$storageRootPath_err"';

The problem I see is that your variables are still in single quotes. Use double quotes and escape the embedded double quyotes, or rather, use qq() to properly interpolate the values. Something like (untested):

my $command = 'ssh '. $node . qq( "perl -e 'while (<>) { chomp; /(.*)\
+\//; `su xxx -c \\"mkdir -p \$1\\"`; `su xxx -c \\"touch \$_\\"`;}' 1
+>>$storageRootPath_log 2>>$storageRootPath_err");

Note how you don't need to escape that much this way — but an embedded backslash needs to be doubled.

[ikegami]

ow! That's not maintainable, assuming it's even correct. Create a script (preferably in advance, but dynamically might work) and see if you could call it using system PROGRAM, LIST to avoid quoting problems. Avoid the headaches!

[jwkrahn]

You can eliminate a lot of the backslashing by using alternative delimiters:

my $command = 'ssh ' . $node . q[ "perl -lne'm!(.*)/! && qx[su xxx -c 
+\"mkdir -p \$1\" && su xxx -c \"touch \$_\"]'] . qq[ 1>> $storageRoot
+Path_log 2>> $storageRootPath_err"];