http://www.perlmonks.org?node_id=594519


in reply to Could I get some feedback on my code please?

NOTE: A quick suggestion for other's looking at the code. Click the download button first thing, so you can see the code formatted nicely in a separate window.

For someone who doesn't write code professionally, writing Perl for their own satisfaction, this is not bad code. You're clearly working at structuring the code for clarity. That's something that takes time to develop, but you've got a good start. Pick up a copy of Perl Best Practices. It's a very readable style guide that you'll probably enjoy reading.

I only have two specific suggestions for the code, at this point in your learning

Good luck, and may you have many happy hours of Perl writing.
  • Comment on Re: Could I get some feedback on my code please?