Re^2: How Much Is Too Much (on one line of code)?

[Jenda]

One does, other doesn't. Just like I do not see any reason to rewrap "Stay at home if it rains." to "If it rains, stay at home." I do not see the need to rewrap statement modifiers.

[duelafn]

The issue is the other conditional.

If the dog is barking let him in otherwise give him a bone, but only if it is raining.

This sentence reads nicer if we place the "if it is raining" earlier in the sentence. I however, would force the truth of $country

my $country = $card->country || 'gbr';
$country = $country eq 'gbr' ? '' : uc "[$country]";

Unfortunately, this breaks when we need to check definedness (until we have a reliable // operator). In that case (assume "0" is a valid country) I would probably go with something like:

my $country = $card->country;
$country = (!defined($country) or $country eq 'gbr') ? '' : uc "[$coun
+try]";

Which is just as complex as the original, but the full conditional is easier to find.

[robot_tourist]

I would add a comma after 'let him in', it splits the clauses better.