Beefy Boxes and Bandwidth Generously Provided by pair Networks
Perl-Sensitive Sunglasses
 
PerlMonks  

Re^3: How Much Is Too Much (on one line of code)?

by duelafn (Vicar)
on Jun 18, 2007 at 15:41 UTC ( #621809=note: print w/replies, xml ) Need Help??


in reply to Re^2: How Much Is Too Much (on one line of code)?
in thread How Much Is Too Much (on one line of code)?

The issue is the other conditional.

If the dog is barking let him in otherwise give him a bone, but only if it is raining.

This sentence reads nicer if we place the "if it is raining" earlier in the sentence. I however, would force the truth of $country

my $country = $card->country || 'gbr'; $country = $country eq 'gbr' ? '' : uc "[$country]";

Unfortunately, this breaks when we need to check definedness (until we have a reliable // operator). In that case (assume "0" is a valid country) I would probably go with something like:

my $country = $card->country; $country = (!defined($country) or $country eq 'gbr') ? '' : uc "[$coun +try]";

Which is just as complex as the original, but the full conditional is easier to find.

Good Day,
    Dean

Replies are listed 'Best First'.
Re^4: How Much Is Too Much (on one line of code)?
by robot_tourist (Hermit) on Jun 20, 2007 at 07:17 UTC

    I would add a comma after 'let him in', it splits the clauses better.

    How can you feel when you're made of steel? I am made of steel. I am the Robot Tourist.
    Robot Tourist, by Ten Benson

Log In?
Username:
Password:

What's my password?
Create A New User
Node Status?
node history
Node Type: note [id://621809]
help
Chatterbox?
and the web crawler heard nothing...

How do I use this? | Other CB clients
Other Users?
Others contemplating the Monastery: (5)
As of 2019-08-24 21:52 GMT
Sections?
Information?
Find Nodes?
Leftovers?
    Voting Booth?

    No recent polls found

    Notices?