Re: Concatnate long statement

[FunkyMonk]

You really don't want a subroutine (it looks like that's what you're doing) with 18 arguments. It's going to cause you all sorts of problems when when you miss one of them out, or get some of them in the wrong order. That number of arguments really gives off a bad code smell.

Refactor your code now, before it's too late.

[Fletch]

And if not refactor, at least switch to using pseudo-named arguments by expecting key/value pairs and appending those to defaults.

sub womble {
  my @defaults = (
    fleem       => 12.3,
    alarm_low   => 99,
    alarm_hi    => 'naked ernest borgnine',
    alarm_hello => 'nice to see you',
    alarm_good_evening => STOP_STEALING_PYTHON_GAGS,
    quux        => 19.95,
  );

  my %args = ( @defaults, @_ );

  if( $args{ quux } > 15 ) { enable_flux_capacitor(); }

  ## ... rest of womblification routine
}

womble( quux => 1.21 * GIGAWATS_PER_MICROFLEEM,
        alarm_low => 42, );

[fenLisesi]

A variation:

use strict;
use warnings;
use Data::Dumper;

my %WOMBLE_DEFAULTS
    = (
       fleem       => 12.3,
       alarm_low   => 99,
       alarm_hi    => 'naked ernest borgnine',
       alarm_hello => 'nice to see you',
       alarm_good_evening => 'STOP_STEALING_PYTHON_GAGS',
       quux        => 19.95,
       );
my $DEBUG = 1;

womble({
    quux => 1.21,
    alarm_low => 42,
});

exit( 0 );

sub womble {
    my ($args_href) = @_;

    %$args_href = (%WOMBLE_DEFAULTS, %$args_href);
    warn Dumper( $args_href ) if $DEBUG;

    ## ... rest of womblification routine
}