Re: Merged lines with Apache::LogFile-based log handler

[derby]

Normally writes (of this size) are atomic so I doubt you need any type of locking mechanism. Looking at the XS code for Apache::LogFile, I see it does mutiple writes - for the message(s) and for the newline if the message(s) does not contain a newline:

 int
print(self, ...)
    Apache::LogFile self

    ALIAS:
    Apache::LogFile::PRINT = 1

    PREINIT:
    int i;
    STRLEN len;
    char *str;

    CODE:
    for(i=1; i<items; i++) {
        str = SvPV(ST(i),len);
        RETVAL += write(self->log_fd, str, len);
    }
    if(*(SvEND(ST(i-1)) - 1) != '\n')
        RETVAL += write(self->log_fd, "\n", 1);

    OUTPUT:
    RETVAL

Under heavy load, what you're seeing is one process being put into a wait state before the newline is output. You don't mention it, but did your logfile also contain blank lines? It should've.

Since you have control, if you append a newline to $message in your _logger method before you print, your logs should come out fine under heavy load.

my $message = qq{$now [$pid] X-Loadbalancer: $lb_value ($status)\n} ;
print Tiscali::LoadBalancerLogFile $message ;

[bronto]

Hello derby

First things first: it worked! Thanks a lot

Second: a small change in apache's configuration is needed: I erroneously configured my module as a Fixup handler, which caused it to be called a huge number of times per line, that amplified the problem. Configuring it as a log handler correctly writes one line at a time. Anyway, I also tested it with the wrong apache configuration, and it still worked, so your solution is absolutely right.

Under heavy load, what you're seeing is one process being put into a wait state before the newline is output. You don't mention it, but did your logfile also contain blank lines? It should've.

Right. I didn't mention it since I pasted an example that contained a blank line. Nevertheless, it was not completely evident. My fault.

Big thanks!!!