Beefy Boxes and Bandwidth Generously Provided by pair Networks
Think about Loose Coupling
 
PerlMonks  

Re: XML::DOM::Parser

by mirod (Canon)
on Mar 08, 2001 at 00:16 UTC ( #62814=note: print w/replies, xml ) Need Help??


in reply to XML::DOM::Parser

Hey, XML::DOM!, My least favorite module!

Here is a more perlish (and which seems to be working fine) version of your code:

#!/bin/perl -w use strict; use XML::DOM; my $parser = new XML::DOM::Parser; my $doc = $parser->parse( \*DATA ) or die "Unable to parse document"; my $root = $doc->getDocumentElement(); # safer than just getting the f +irst # child, in case the document h +as a # DTD or start with comments scanner($root); sub scanner { my ($rt) = @_; my $i=0; foreach my $nde ( $rt->getChildNodes()) # yes it is an +array! { if ( ($nde->getNodeType() == TEXT_NODE ) && ($nde->getData()=~ /\S/s) ) # to avoid extr +a white spaces { #$log->info( $i.$nde->getNodeValue()); print $i++," TEXT /", $nde->getData(), "/\n"; } if ($nde->getNodeType == ELEMENT_NODE) { #$log->info( $i.$nde->getNodeName()); print $i++, " ELEMENT ", $nde->getNodeName(), "\n"; } scanner( $nde ); } } __DATA__ <methodCall>Level1 Text <Level2a>Text at Level2a</Level2a> <Level2b>Text at Level2b</Level2b> </methodCall>

Some explanations:

  • Yes there are plenty of white spaces in your document. The DOM states that they should be reported to the application. In your case I think you can ignore "pure white spaces" If you have a choice you should also wrap the text at level 1 in a tag, it would make it easier to ignore the trailing spaces and it would generally be cleaner. Especially if you are dealing with data-oriented XML it is a good idea to avoid mixed-content (text such as Level1 Text and elements (Level2a and Level2b) mixed within an element (methodCall).
  • If you want to program in Java you should write Java code. Seriously XML::DOM uses Perl native types such as arrays, you should take advantage of it. The DOM is enough of a pain as it is, no need to make it even more painful. As for the oft heard argument than this is different than the Java API, even Java programmers seem to be ditching the DOM in favour of JDOM (motto "Say NO to DOM"), a simpler interface to the strict binding defined by the W3C so...
  • use $root=  $doc->getDocumentElement() instead of getFirstChild(), that will save you some trouble the day your XML document comes with a DTD or leading comment, which is perfectly legal

Replies are listed 'Best First'.
Re: Re: XML::DOM::Parser
by spoddie (Initiate) on Mar 08, 2001 at 05:54 UTC
    Well, thank you very much for this detailed reply. It makes it a lot clearer to me where I am going wrong. I'm still struggling with perl syntax to be honest (and yes I am a C/Java programmer, it probably shows!).

    I hope to try this out when I return to the office tomorrow, hope one day I can be of assistance to someone !

Log In?
Username:
Password:

What's my password?
Create A New User
Node Status?
node history
Node Type: note [id://62814]
help
Chatterbox?
and the web crawler heard nothing...

How do I use this? | Other CB clients
Other Users?
Others drinking their drinks and smoking their pipes about the Monastery: (3)
As of 2021-03-03 21:50 GMT
Sections?
Information?
Find Nodes?
Leftovers?
    Voting Booth?
    My favorite kind of desktop background is:











    Results (94 votes). Check out past polls.

    Notices?